Skip to content

Test schema_version_check directly

Thong Kuah requested to merge test_schema_version_check_directly into master

What does this MR do?

Un-quarantines spec/tasks/migrate/schema_check_rake_spec.rb

Changes spec to invoke schema_version_check instead. Testing via db:migrate causes side-effects like setting ActiveRecord::Base.configurations and also it runs schema dump into db/schema.rb. Rather than keep up, we test schema_version_check directly

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63913

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading