Skip to content

Allow specifying variables when running manual jobs

Matija Čupić requested to merge mc/feature/manual-job-variables into master

What does this MR do?

EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14784

  • Backend
    • Write Job variable application code
    • Write Job variables database migration
    • Write Job variable specs
  • Frontend
    • Create component with form
    • Render the manual variables component when playable only
    • Handle secret value change
    • POST request
    • Update the text
    • Add specs
Screenshot_2019-07-17_at_10.29.42 Screenshot_2019-07-17_at_10.30.05
Screenshot_2019-07-17_at_10.30.41 Screenshot_2019-07-17_at_10.31.33

Does this MR meet the acceptance criteria?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24935

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • N/A Label as security and @ mention @gitlab-com/gl-security/appsec
  • N/A The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • N/A Security reports checked/validated by a reviewer from the AppSec team
Edited by Matija Čupić

Merge request reports

Loading