Skip to content

Adds direct monitoring for sidekiq metrics

Ryan Cobb requested to merge 56752-replace-sidekiq-metrics into master

What does this MR do?

This MR adds instrumentation to directly monitor sidekiq. It does this in two ways:

  1. By sampling the sidekiq api from the main app server thread (see SidekiqSampler)
  2. By adding metrics middleware to sidekiq server (see SidekiqMiddleWare::Metrics)

This adds all metrics from #56752 (closed) besides sidekiq_jobs_returned_to_redis_total. More work will be needed to figure out how to directly monitor that.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #56752 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading