Skip to content

Fix secpick pushing to stable branch

Thong Kuah requested to merge fix-secpick into master

What does this MR do?

secpick is checking out a tracked branch from dev/X-Y-stable, and then the push of that branch pushes to the stable branch 😱

Luckily I don't have access to push to stable branches.

To dev.gitlab.org:gitlab/gitlab-ee.git
 ! [remote rejected]         my-new-branch -> 12-1-stable-ee (pre-receive hook declined)
error: failed to push some refs to 'git@dev.gitlab.org:gitlab/gitlab-ee.git'

This fixes secpick to not track dev/X-Y-stable so that the push of the new branch will create a new branch on dev

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading