Skip to content

Fix the style-lint errors and warnings for wiki.scss

Himanshu Kapoor requested to merge 59829-fix-style-lint-wiki into master

What does this MR do?

Fixes style lint errors in app/assets/stylesheets/pages/wiki.scss.

~backstage

Screenshots

Before After
wiki home before_home after_home
wiki edit before_edit after_edit
wiki git access* before_git_access after_git_access
wiki history before_history after_history
wiki pages before_pages after_pages
wiki show before_show after_show
  • -Note that on the wiki git access page, the clone path dropdown is broken in both before and after screenshots. I will create an issue for it and fix in a separate MR.- Opened - #66022 (closed)

Does this MR meet the acceptance criteria?

Basic Tasks

  • If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
  • Double check if all the warning have been fixed by running yarn run stylelint-file app/assets/stylesheets/pages/wiki.scss
  • In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
  • If there are a lot of changes, we recommend to break them into smaller MRs
  • Double check the usage of each changed class both in CE and EE
  • EE changes should either be backported into CE or moved into ee/ folder. You can read more about how to handle EE code here
  • Label the MR with ~CSS cleanup

Conformity

Closes #59829 (closed)

Edited by Himanshu Kapoor

Merge request reports