Skip to content

Don't use go mod vendor

Nick Thomas requested to merge (removed):do-not-vendor-go-mod into master

What does this MR do?

This change comes out of a discussion between @bjk-gitlab and me, around this MR: gitlab-pages!164 (merged)

gitlab-elasticsearch-indexer already uses go mod without a vendor/ directory. It has caused some intermittent build failures in the gitlab-ce/ee CI pipelines, but has otherwise been fine. I think that treating our Go dependencies in the same way we do our Ruby or Node.js ones is reasonable, and it has some minor benefits:

  • Contributors find it easier to submit MRs
  • MRs are easier to review
  • Makefiles are easier to write

Merge request reports

Loading