Skip to content

Fixed border styles for callout

Aishwarya Subramanian requested to merge callout-border-fix into master

What does this MR do?

The callout has additional borders as compared to the design spec when used with the .alert class, which sets a 1px transparent border all around the container, and then is visible once the .bs-callout class is used: https://gitlab-org.gitlab.io/gitlab-design/hosted/design-gitlab-specs/alerts-spec-previews/

This MR fixes the border styles by:

  1. Adding 3px border on left side
  2. Removes border on all other sides

This effectively ports the callout SCSS changes from the EE MR: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14714

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #66000 (closed)

Edited by Aishwarya Subramanian

Merge request reports

Loading