Build correct variables for testing translations
What does this MR do?
I noticed we started using different variable types in our singular vs plural translation id's.
Because of https://gitlab.com/gitlab-org/gitlab-ce/issues/48110 this will work for frontend translations. We're still only allowing one interpolation type per id. So I think we can support this.
This adjusts the tests, so when trying out a translation with interpolation, it takes the corresponding msgid
or plural_id
as source for the variables to be interpolated.
This came up in https://gitlab.com/gitlab-org/gitlab-ce/issues/64739
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48110
Conformity
- [-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
- [-] Documentation created/updated or follow-up review issue created
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team