Skip to content

Add Gitaly info-ref cache feature flags

Paul Okstad (ex-GitLab) requested to merge po-inforef-feature-flags into master

What does this MR do?

This change adds two new feature flags to enable new features in Gitaly for the caching of the info-ref upload pack RPC.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

These feature flags should not affect quality or performance until enabled. Upon enablement, they are designed to increase the performance of the Git HTTP info-ref advertisement when used with the appropriate version of Gitaly (see gitaly!1366 (merged)).

Additional test coverage in GitLab-CE should not be necessary since the cache feature should be transparent to clients (i.e. GitLab Rails).

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of: gitaly#1631 (closed)

Edited by Zeger-Jan van de Weg

Merge request reports

Loading