Remove usage of gitlab-shell gitlab-keys script
What does this MR do?
Remove the fallback path from gitlab-ce and sets default authorized_keys_file
setting.
The default authorized_keys_file
setting is the same as gitlab-shell's default. This is to ensure that it's always set.
It needs to be the same as gitlab-shell's default because we don't set a default value in omnibus-gitlab. If users don't set the value of that config in their install and they upgraded, we must ensure that it's still going to point to the same authorized keys file.
gitlab-shell MR to remove gitlab-keys script: gitlab-shell!329 (merged)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Bajao