Skip to content

Resolve "Use Visual Review Tools NPM package"

Scott Hampton requested to merge 66402-use-visual-review-tools-npm-package into master

What does this MR do?

Currently we have duplicate code in the https://gitlab.com/gitlab-org/visual-review-tools and in CE. We want the visual-review-tools repo to be the master, and for CE to install the NPM package as a dependency and copy it over to the assets in webpack.

Related issue: visual-review-tools#9 (closed) Related issue: #66402 (closed)

What I did to test success

Before, the visual_review_toolbar.js code could be found at /assets/webpack/visual_review_toolbar.js.

After, I ran the new webpack configuration and ran the application. The asset was found at http://localhost:3000/assets/webpack/visual_review_toolbar.js. Right where it was before.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Edited by Scott Hampton

Merge request reports

Loading