Support selective highlighting of lines
What does this MR do?
Instead of highlighting all lines when not all of them are needed, only highlight from the beginning up to the specified limit.
The BlobPresenter#highlight
method has been updated to support to
param. This param will be used to limit the content to be highlighted.
Some simple benchmark results:
[1] pry(main)> lines = "line\n" * 1000
[2] pry(main)> Benchmark.ms { Gitlab::Highlight.highlight('lines', lines, language: 'ruby') }
=> 27.875000028871
[3] pry(main)> Benchmark.ms { Gitlab::Highlight.highlight('lines', lines.lines[0..419].join, language: 'ruby') }
=> 13.919000048190355
This is based from an old MR that has been reverted due to a bug it introduced: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31361.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. - [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Bajao