Break circular dependency in image_diff
What does this MR do?
Breaks circular dependency in image_diff by introducing new helper
Before
graph LR;
image_diff/image_diff --> image_diff/helpers/index
image_diff/helpers/index --> image_diff/helpers/utils_helper
image_diff/helpers/utils_helper --> image_diff/replaced_image_diff;
image_diff/replaced_image_diff --> image_diff/image_diff;
After
graph LR;
image_diff/image_diff --> image_diff/helpers/index
image_diff/helpers/index --> image_diff/helpers/utils_helper
image_diff/replaced_image_diff --> image_diff/image_diff;
sq[image_diff/init_image_diff] --> image_diff/image_diff;
image_diff/helpers/utils_helper -.-> image_diff/replaced_image_diff;
sq[image_diff/init_image_diff] --> image_diff/replaced_image_diff;
classDef orange fill:#f96
class sq orange
We're using default export with object, instead of directly exporting function in order to be able to use mocking in tests, instead of rewiring
See #67206 (moved) for details
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Edited by Illya Klymov