Skip to content

Change update interval of runners when trying to preserve contacted_at

What does this MR do?

Changes how often we update ci_runners table. This change makes it to update 60 times less.

Are there points in the code the reviewer needs to double check?

Maybe we could move contacted_at out of database and store this data in persistent storage of Redis. This probably be way more efficient then ci_runners.

Why was this MR needed?

We see a large amount of vacuuming on ci_runners table. We constantly update only this value, so this seems to be reason why it happens.

Drawbacks

We have a stuck runners feature. It will make this feature less usable, because before we discover that runner is dead it will have to pass 2 hours.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/21698

Merge request reports

Loading