build: replace golint with revive and staticcheck
What does this MR do?
golint was deprecated:
See https://github.com/golang/go/issues/38968 and https://github.com/golang/lint/commit/6edffad5e6160f5949cdefc81710b2706fbcd4f6
See https://github.com/golangci/golangci-lint/pull/1965, https://github.com/golangci/golangci-lint/issues/1892 and https://github.com/golangci/golangci-lint/commit/f95b1ed39fb58390dbde896948f3d93435488c76
Golint recommends staticcheck
but golangci is using revive
as a replacement (feature-wise)
TODO
-
I added the Changelog
trailer (e.g.Changelog: feature
) to the commits that need to be included in the changelog -
I added unit tests or they are not required -
I added acceptance tests or they are not required -
I added documentation (or it's not required) -
I followed code review guidelines -
I followed Go Style guidelines