refactor: delay domain resolution and refactor acme tests
What does this MR do?
Blocked by !736 (merged)
The goal of this MR is to have 0 domain resolution request if the request is not an acme request.
If the request is an acme request then the domain needs to be resolved once but that's fine because we're handling the request in the acme middleware at that point, it's not going to be passed to parent middlewares.
As a side effect we can delay domain resolution further in the middleware chain (and even further once a couple more MR are unlocked).
Acme tests are also refactored to cover more cases.
TODO
-
I added the Changelog
trailer (e.g.Changelog: added
) to the commits that need to be included in the changelog -
I added unit tests or they are not required -
I added acceptance tests or they are not required -
I added documentation (or it's not required) -
I followed code review guidelines -
I followed Go Style guidelines
Edited by feistel