Draft: Add a NoVersionCheck instance
What does this MR do and why?
As per gitlab-org/quality/quality-engineering/team-tasks#3071
Addressing the failures at https://gitlab.com/gitlab-org/quality/ci/secure-testing/version-matrix/-/pipelines/1575616218 for gitlab-org/quality/ci/secure-testing/version-matrix!1
This adds an "instance" to allow the use of a specified image, but it also runs a rails command to disable the security version check modal on login.
Without it, if we spin up and test against an older instance image, this modal fails our specs on login (see screenshot)
Screenshots or screen recordings
Modal prior to the rails command being set:
How to set up and validate locally
gitlab-qa % CHROME_DISABLE_DEV_SHM=true ./exe/gitlab-qa Test::Instance::NoVersionCheck gitlab/gitlab-ee:16.5.0-ee.0 --no-teardown -- --color qa/specs/features/ee/browser_ui/13_secure/
If you want you can login to the docker container and verify:
docker container ls
CONTAINER ID ...
e16c71b21398 ...
Use this ID
docker exec -it e16c71b21398 /bin/bash
and verify
# gitlab-rails console
irb(main):001:0> Gitlab::CurrentSettings.version_check_enabled
=> false
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
Commits include Changelog:
trailer -
I have evaluated the MR acceptance checklist for this MR.