Skip to content

Remove file locking for Windows

Steve Xuereb requested to merge remove-windows-locking into master

What does this MR do?

Remove file locking for Windows

Why was this MR needed?

We use https://github.com/gofrs/flock for file locking and looking a the Windows implementation in https://github.com/gofrs/flock/blob/5135e617513b1e6e205a3a89b042249dee6730c8/flock_windows.go#L89-L99 we see that the library is using an exclusive lock (https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-lockfileex) which locks for every process, even things like Get-Content and not specific for gitlab-runner run like Linux.

For windows we might want to relay on something else apart from file locking primitives since it works differently on Windows.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#4691 (closed)

Merge request reports

Loading