Update stretchr/testify library to fix flaky test
What does this MR do?
Update stretchr/testify library to fix flaky test
Why was this MR needed?
TestBuildsHelperCollect panics from time to time for example
https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/769151804 because, we
are using
Eventually
and there is a bug where it tries to write to a
channel
that is closed by a
defer.
Since the write is in it's own goroutine it can be the case that the
goroutine is schedule after the function returns which closes the
channel. Newer version of testify aren't effected by this because
Eventually
was re-written and fixed in https://github.com/stretchr/testify/pull/808
What's the best way to test this MR?
Take a look at the go.mod and go.sum file changes to make sure everything is updated accordingly.
What are the relevant issue numbers?
Closes #27037 (closed)
Edited by Steve Xuereb