Stop considering docker pull image as runner system failure
What does this MR do?
With this MR, the docker pull image error is no more considered as a runner system error
Why was this MR needed?
What's the best way to test this MR?
Here are the configuration file needed to test this MR:
.gitlab-ci.yml
variables:
DURATION: 60
job:
script:
- 'for i in $(seq 1 $DURATION); do echo $(date); sleep 1; done'
- echo "done"
config.toml for docker executor
concurrent = 1
check_interval = 0
[session_server]
session_timeout = 1800
[[runners]]
name = "Local GitLab Runner for tests and debugging - Docker"
url = "https://gitlab.com"
token = "YOUR_TOKEN_HERE"
executor = "docker"
[runners.docker]
tls_verify = false
image = "dummyimage"
privileged = false
disable_entrypoint_overwrite = false
oom_kill_disable = false
disable_cache = false
volumes = ["/cache"]
shm_size = 0
config.toml for kubernetes executor
concurrent = 1
check_interval = 0
[session_server]
session_timeout = 1800
[[runners]]
name = "kubernetes"
url = "https://gitlab.com/"
token = "TOKEN_HERE"
executor = "kubernetes"
[runners.kubernetes]
image = "dummyimage"
privileged = true
namespace = "default"
- Run a job using the configurations above
- The job fails with the following error:
Job Failure error for Docker executor
ERROR: Job failed: failed to pull image "dummyimage" with specified policies [always]: Error response from daemon: pull access denied for dummyimage, repository does not exist or may require 'docker login': denied: requested access to the resource is denied (manager.go:205:1s)
Job Failure error for Kubernetes executor
ERROR: Job failed: prepare environment: waiting for pod running: pulling image "dummyimage": image pull failed: rpc error: code = Unknown desc = Error response from daemon: pull access denied for dummyimage, repository does not exist or may require 'docker login': denied: requested access to the resource is denied. Check https://docs.gitlab.com/runner/shells/index.html#shell-profile-loading for more information
What are the relevant issue numbers?
closes: #27880 (closed), #28037 (closed)
Edited by Romuald Atchadé