Skip to content

Add warning about using SIGTERM/SIGINT over SIGQUIT

What does this MR do?

This adds an additional warning if the interrupt received is not SIGQUIT.

Why was this MR needed?

In local development, interrupting the runner with a signal other than SIGQUIT will not gracefully clean up all plugins, eg. using ctrl-c.

What's the best way to test this MR?

While running the runner locally, if you terminate it with ctrl-c, it should print this added message. If you terminate the runner with ctrl-\, it should terminate gracefully without printing this message.

What are the relevant issue numbers?

#29463 (closed)

Notes

This is my first MR, so apologies if I've missed anything obvious, and thanks in advance for your review. The linked issue mentions to specifically handle SIGTERM, but I believe ctrl-c sends SIGINT instead.

Edited by Phil Nichol

Merge request reports

Loading