Remove stray omitempty in long form for --docker-devices
What does this MR do?
This merge request removes a stray omitempty
option from the --docker-devices
long form.
Why was this MR needed?
This stray tag caused some problems with parsing the flag. When passing --docker-devices a
to the runner, it would actually parse it as two separate arguments, and result in the devices a
and [a]
. I believe that this option is not required here, as this is the only item where the long
tag contains this.
What's the best way to test this MR?
Build gitlab-runner with and without this MR. Before, when you pass --docker-devices a
while registering a runner, generated config file would look like this:
[[runners]]
[runner.docker]
devices = ["a", "[a]"]
Running the same command with this MR results in the following, which is correct
[[runners]]
[runner.docker]
devices = ["a"]
What are the relevant issue numbers?
None that I know of