Fix Documentation for privileged mode
What does this MR do?
The helm value runners.privileged
no longer exists. The right value now is securityContext.privileged
as per values.yaml, in which case securityContext.allowPrivilegeEscalation
must also be set to true
to work.
Why was this MR needed?
Out of date documentation with incorrect instructions.
What's the best way to test this MR?
helm upgrade --install gitlab-runner gitlab/gitlab-runner --namespace gitlab-runner --create-namespace --set "runnerToken=$RUNNER_TOKEN" --set "gitlabUrl=https://gitlab.com/" --set "securityContext.privileged=true" --set "securityContext.allowPrivilegeEscalation=true"
kubectl get deploy gitlab-runner -n gitlab-runner -o yaml | grep -i 'privi'
allowPrivilegeEscalation: true
privileged: true
What are the relevant issue numbers?
Edited by Lev R