Skip to content

Avoid SIGTERM propagation to processes on Windows OS

Romuald Atchadé - OOO from 2024-12-23 to 2025-01-03 requested to merge docker-propagate-signal-to-pids into main

What does this MR do?

In !4446 (merged), we add a new way to force the termination of PIDs within a container for executordocker. The implementation was running this command on both Windows and Linux containers even though the script is not windows compatible.

The execution was not also taking in account the case when the build container has already exited before the execScriptOnContainer is ran.

Why was this MR needed?

With this MR, the execScriptOnContainer is only run for linux container and the error are logged only when the error returned is nor errdefs.IsConflict or docker.IsErrNotFound

What's the best way to test this MR?

What are the relevant issue numbers?

Edited by Romuald Atchadé - OOO from 2024-12-23 to 2025-01-03

Merge request reports