Skip to content

Fix graceful termination of jobs on Windows

Nils Gladitz requested to merge nilsgladitz/gitlab-runner:try-to-fix-462181 into main
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do?

It tries to fix the graceful termination issue of jobs on Windows I reported in gitlab#462181 (closed)

Why was this MR needed?

Because graceful termination is otherwise not possible with runners on Windows.

What's the best way to test this MR?

Run the corresponding integration tests (which I've update) e.g.: go test gitlab.com/gitlab-org/gitlab-runner/helpers/process -tags integration -v

What are the relevant issue numbers?

gitlab#462181 (closed)

@ajwalker

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading