Skip to content

Fix bug in scripts/logs dir for k8s executor

Thomas John Randowski requested to merge WojoInc/gitlab-runner:fix_base_dirs into main
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do?

Corrects some typo/logic issues in the config options added as part of !4805 (merged).

This MR changes the behavior of logs_base_dir and scripts_base_dir to align with their descriptions in the runner documentation, and their original intended behavior.

This is because some of the edits made during review resulted in paths that do not include /logs or /scripts.

As a workaround, users can set logs_base_dir and scripts_base_dir to different paths, but this doesn't address documentation or fix the config options to follow their intended functionality.

See linked issue for more details

Why was this MR needed?

To correct a bug introduced in the new config options added as part of !4805 (merged).

While accepting some of the suggestions provided by reviewers, I missed some things in my review that altered the proposed functionality. As it stands currently, the documentation here does not reflect the actual behavior of the config options.

This MR corrects the behavior of the config options to match the documentation and how I'd originally intended them to function.

What's the best way to test this MR?

Deploy GitLab runners using the k8s executor. Set runner config options as outlined here

What are the relevant issue numbers?

close #37895 (closed)

Edited by Romuald Atchadé - OOO from 2024-12-23 to 2025-01-03

Merge request reports