Skip to content

Custom executor script shouldn't end with '.' when no file extension

Arran Walker requested to merge 37899-ci-cd-runner-run_exec-script-file-name-is-incorrect into main

What does this MR do?

When there's no file extension for the shell script generated we were still adding a ".". This appears to have problems in a MinGW-based environment.

What's the best way to test this MR?

Existing tests should continue to work. Bash scripts as part of our tests would have been using script. so as long as tests still pass now that the . has gone, we're good.

We could potentially add an explicit test for checking that the produced file doesn't end with ., but this might be overkill/there's no existing test to base this kind of check on.

What are the relevant issue numbers?

Closes #37899 (closed)

Merge request reports