Introduce Context in Build.Run
requested to merge 2922-data-race-in-function-executors-virtualbox_test-testvirtualboxbuildcancel-func1-executors-virtualbox-executor_virtualbox_test-go-194 into master
What does this MR do?
Build.Run
now receives a Context
from outside that will be used as parent
context for setting the timeout.
Now common.JobTrace
is a context provider and this simplifies the CancelFunc
handling in network.JobTrace
that no longer needs to get access to Build
internal CancelFunc
.
Furthermore, this simplification allows the introduction of Build.Cancel()
All this sharing of CancelFunc
, was the root cause of the data race in #2922 (closed)
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Closes #2922 (closed)
Edited by Alessio Caiazza