Skip to content

Stop including application.css

Enrique Alcántara requested to merge do-not-include-application-css into master

This MR removes the inclusion of gitlab-ce stylesheet on design.gitlab.com. This proposal has advantages and disadvantages:

Disadvantages

The vue component tab does not look the same

Before After
Screen_Shot_2019-08-05_at_8.51.40_AM Screen_Shot_2019-08-05_at_8.51.49_AM

Components not styled in gitlab-ui won’t appear as styled in design.gitlab.com

Before After
Screen_Shot_2019-08-05_at_8.55.16_AM Screen_Shot_2019-08-05_at_8.55.04_AM

Advantages

Components not styled in gitlab-ui won’t appear as styled in design.gitlab.com

  • It gives us a strong visual indication of which components are not styled according to the specs yet.
  • It gives us a strong visual indication of which components are not styled in gitlab-ui yet.
  • It helps us to avoid CSS conflicts between gitlab-ui and gitlab-ce. gitlab-ui will be a SSOT for component styles based on pajamas.

More control

  • Changes in gitlab-ce won’t cause unexpected consequences in design.gitlab.com
  • We don’t have to worry about how gitlab-ce styles will conflict with design.gitlab.com CSS.
Edited by 🤖 GitLab Bot 🤖

Merge request reports