feat(GIPopover): adds close button examples to popover docs
What does this MR do?
As a designer, I wanted to see how the close button looks on popovers, so I can create an artefact that communicates with the GitLab team.
This change adds examples that use the show-close-button
option to the Implementation tab.
- Close button
- No title with close button
Out of scope
- The close button alignment looks like it has a bug.
- Creating Figma component (See #1233 (closed))
Does this MR meet the acceptance criteria?
-
The MR title and commit message meet the Pajamas commit conventions -
Add a description to this MR explaining the reasons for the proposed change, per say-why-not-just-what -
Include MR scope that reflects the purpose of the change in the description - For example, if this MR is focused on
usage guidelines
, addressingaccessibility challenges
could be added separately with a different MR
- For example, if this MR is focused on
-
If creating a new page on Pajamas from scratch, follow the page template structure -
Follow the Pajamas Voice & Tone Guidelines and GitLab Documentation Style Guide -
Link components to and from other related components and patterns on the .md
file, where helpful -
If embedding a Figma file, follow the Figma embed guide -
Assign it to a reviewer. All GitLab designers are reviewers, but you can also assign it directly to a maintainer or trainee maintainer -
Apply the correct component label(s) -
Select a milestone or due date
Links
Edited by Dan MH