Skip to content

fix(css): Button text ellipsis

David O'Regan requested to merge 758 into master

What does this MR do?

This MR is a tiny MVC for: #758 (closed)

In this MR we attempt to add the smallest amount of code possible to enable two things:

  1. Even padding on buttons as screens scale
  2. Allow button text to truncate

Screenshots

Screenshot_2020-05-05_at_18.30.39

Questions

UX: Do we need a specific width for the buttons to truncate?

FE: Should we add a storybook example as you have in the dropdowns MR?

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by David O'Regan

Merge request reports

Loading