fix(GlButton): Add conditional for icon
What does this MR do?
A tiny MVC to address: #775 (closed)
Since we wrap our button text slot
in a class we add a conditional to ignore that span on Icon only buttons so we don't create extra spacing to the right.
<span v-if="!hasIconOnly" class="gl-button-text"><slot></slot></span>
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
Customers Portal: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Edited by David O'Regan