Skip to content

Resolve "Selected item from Recent searches doesn't populate search input"

Illya Klymov requested to merge xanf-forward-events-from-search into master

What does this MR do?

This MR properly wires events from gl-search-box-by-click to gl-filtered-search Additionally selecting history item does not trigger submit event anymore Instead new history-item-selected event will be triggered

This allows customizing behavior of our search components when needed.

Although this is marked as breaking change (because of changing component behavior) none of consumers (GitLab, Customers Portal, Status Page) were using search-box-by-click or gl-filtered-search with history-items prop, so no integration MRs are needed

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Closes #813 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading