Skip to content

feat(modal): Set correct height calculation for modals with scrollable content

Enrique Alcántara requested to merge modal-scrolling-max-height into master

What does this MR do?

When the scrollable property is set in the modal component and content overflows the modal’s body height, the modal component’s body will display a vertical scroll bar. This MR creates documentation for this behavior. We’ve customized the margins of the modal component so this MR also tweaks the height calculation to account for these customizations.

Screenshots

Small screen Default
Screen_Shot_2020-06-05_at_9.39.19_AM Screen_Shot_2020-06-05_at_9.39.06_AM
Loom video
Loom thumbnail
Link

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports