Skip to content

fix(GLTokenSelector): move text input specific HTML attributes from container to text input

Peter Hegman requested to merge token-selector-input-attributes into master

What does this MR do?

There are a few useful HTML attributes that should be on the text input instead of the token selector wrapper. This adds props for autocomplete, aria-labelledby and placeholder and adds those attributes to the text input.

Screenshots

autocomplete is the only attribute that causes a visual change:

No tokens selected

Screen_Shot_2020-06-22_at_2.48.57_PM

Tokens selected

Screen_Shot_2020-06-22_at_2.49.18_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Peter Hegman

Merge request reports

Loading