Skip to content

fix(search-box-by-type): Fix clear button focus

Nathan Friend requested to merge nfriend-fix-search-box-by-type-focus-attempt-3 into master

What does this MR do?

This is the exact same change as !1521 (merged). See that MR for a description of the changes and GIFs.

Context

  1. I submitted !1521 (merged), which was approved and merged. However, this caused Jest test failures in gitlab-org/gitlab (see gitlab!35409 (merged)).
  2. I reverted the MR above with !1527 (merged).
  3. I attempted to fix this bug using a different approach in !1529 (closed), but closed this MR when I decided to fix the root testing issue.
  4. We fixed the root testing issue in gitlab!36014 (merged)
  5. I opened this MR 🙂

Integration branch

Here is a test MR that integrates these changes into gitlab-org/gitlab: gitlab!36450 (closed).

Note that the pipeline will never fully succeed because the danger-review job is unhappy about the commit message. However, all other jobs (particularly the jest jobs) should pass.

Edited by Nathan Friend

Merge request reports