fix(GlTokenSelector): fix padding override
What does this MR do?
Removes the gl-py-2
utility class from the text input. It is unneeded because the padding is defined in src/components/base/token_selector/token_selector.scss#L10.
When looking at the component in Storybook you won't notice a difference because .gl-token-selector-input
overrides .gl-py-2
. In the gitlab-org/gitlab
codebase .gl-py-2
is imported after .gl-token-selector-input
so it overrides the padding and causes a slight issue with the padding when no tokens are selected.
If you want to see this in the gitlab-org/gitlab
codebase take a look at the "Restrict membership by email domain" field on the /groups/{group_name}/-/edit
page
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. - [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
- [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
- [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the
@gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
Customers Portal: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Edited by Peter Hegman