feat(css): Add missing sm margin and fix class order issue
What does this MR do?
Need for classes exposed as part of: gitlab!36867 (comment 380129940)
-
Adds
gl-sm-mx-0
=> Remove horizontal margin aftersm
breakpoint. -
The order of responsive classes was causing a bug when trying to apply
gl-sm-w-auto
in tandem withgl-w-full
. Sincegl-w-full
was lower in the file than the breakpoint class, it was always overridden. Then problem was unfixable as the!important
classes do not currently generate for responsive classes. See: #871 (closed)
I believe having the responsive classes after all the static classes should remedy this issue. I also checked and there are currently no uses cases of gl-sm-w-auto
in GitLab.org, Custom portal, or Status page:
No Uses | |
---|---|
Customer Portal | |
Status Page | |
GitLab.org |
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
Customers Portal: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Edited by Zack Cuddy