Skip to content

Replace pseudo selector with class

Savas Vedova requested to merge 900-gl-button-disabled-state into master

What does this MR do?

Fixes the disabled state as mentioned in #900 (closed).

The following gif is only illustrative, the examples have not been updated. The only issue remains the cursor. Since we have a pointer-events: none attached to .disabled links, the not allowed cursor is not being displayed. A possible solution could be adding a wrapper around buttons with disabled state and to property defined. But I think that should be handled in a separate issue in case it's needed.

In the following example Secondary Success is a disabled button (so the current behaviour is kept) and the link button is actually, well, a link.

button

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports