Skip to content

fix(dropdown): Dropdown can accept `null` text values

Miguel Rincon requested to merge mrincon/dropdown-renders-for-null-text into master

What does this MR do?

Dropdown accepts null text values

Dropdown text defaults to the empty string but there might be cases in which users send a null value to the text prop.

In this case the dropdown should still be displayed.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.
Edited by Miguel Rincon

Merge request reports