Skip to content

fix(dropdown): Correct margin for dropdown headers

Taurie Davis requested to merge dropdown-header-margin into master

What does this MR do?

Currently, dropdown headers have no margin bottom. This means list items rest right up against the divider. This MR adds a margin bottom.

Before After
Screen_Shot_2020-09-16_at_8.47.17_AM Screen_Shot_2020-09-16_at_8.46.54_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports

Loading