Skip to content

chore: Silence warning about missing moment.js library

Vitaly Slobodin requested to merge vs-silence-warning-about-moment into master

What does this MR do?

We dropped moment.js library some time ago and pikaday library causes the following warning to appear in the build log:

WARNING in ./node_modules/pikaday/pikaday.js
Module not found: Error: Can't resolve 'moment' in '/builds/gitlab-org/gitlab-ui/node_modules/pikaday'
 @ ./node_modules/pikaday/pikaday.js
 @ ./node_modules/babel-loader/lib??ref--6!./node_modules/vue-loader/lib??vue-loader-options!./src/components/base/datepicker/datepicker.vue?vue&type=script&lang=js&
 @ ./src/components/base/datepicker/datepicker.vue?vue&type=script&lang=js&
 @ ./src/components/base/datepicker/datepicker.vue
 @ ./index.js
 @ ./src/components/base/form/form_input_group/form_input_group.stories.js
 @ ./src/components/base/form/form_input_group sync nonrecursive ^\.\/(?:(?:form_input_group\.stories\.js)$)$
 @ ./.storybook/generated-entry.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/preview.js ./node_modules/@storybook/addon-knobs/dist/preset/addDecorator.js ./.storybook/generated-entry.js

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vitaly Slobodin

Merge request reports

Loading