Skip to content

fix(GlDropdown): apply proper classes for secondary category

Paul Gascou-Vaillancourt requested to merge dropdown-secondary-classes into master

What does this MR do?

This ensures that GlDropdown's toggle's classes are set properly.

A change introduced in !1645 (merged) is preventing the secondary category from being properly handled in GlDropdown. This MR fixes that by aligning the classes being applied on the dropdown's toggle with the ones defined in GlButton's styles.

Before After
Screen_Shot_2020-10-06_at_11.34.13_AM Screen_Shot_2020-10-06_at_11.34.46_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Gascou-Vaillancourt

Merge request reports

Loading