Skip to content

feat(GlColumnChart): Add 2nd Y-axis for column and stacked column chart

What does this MR do?

Updates the column and stacked-column components to provide props for a secondary Y axis, the secondary axis is specified using an optional prop and has the same structure as the data provided for bars or lines introduced in !1703 (merged).

  • Adds the secondaryData prop
  • Adds the secondaryDataTitle prop

Screenshots

Stacked column Stacked line Column Column + line
Screen_Shot_2020-10-14_at_3.30.35_pm Screen_Shot_2020-10-14_at_3.30.44_pm Screen_Shot_2020-10-14_at_3.31.03_pm Screen_Shot_2020-10-14_at_3.31.18_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #932 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading