Skip to content

fix(GlLabel): Fix label spacing and overflow

Coung Ngo requested to merge cngo-fix-label-spacing-and-overflow into master

What does this MR do?

This MR fixes 2 issues raised in gitlab#216881 (comment 429633299) and gitlab#216881 (comment 429609155):

  • The wide spacing between the label title and x button is improved
  • A very long label title pushing the x button of visibility is fixed

Screenshots

Spacing fix:

label type before after
unscoped Screenshot_2020-10-14_at_5.52.22_pm Screenshot_2020-10-14_at_5.52.33_pm
scoped Screenshot_2020-10-14_at_5.52.10_pm Screenshot_2020-10-14_at_5.52.42_pm

Overflow fix:

label type before after
unscoped Screenshot_2020-10-14_at_6.16.02_pm Screenshot_2020-10-14_at_6.16.17_pm
scoped Screenshot_2020-10-14_at_6.14.51_pm Screenshot_2020-10-14_at_6.15.14_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports

Loading