fix(GlLabel): Fix label spacing and overflow
What does this MR do?
This MR fixes 2 issues raised in gitlab#216881 (comment 429633299) and gitlab#216881 (comment 429609155):
- The wide spacing between the label title and
x
button is improved - A very long label title pushing the
x
button of visibility is fixed
Screenshots
Spacing fix:
label type | before | after |
---|---|---|
unscoped | ||
scoped |
Overflow fix:
label type | before | after |
---|---|---|
unscoped | ||
scoped |
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
Customers Portal: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo