Skip to content

feat(GlDropdown): Add loading state to dropdown

Coung Ngo requested to merge cngo-dropdown-loading-state into master

What does this MR do?

This MR adds a loading state to the dropdown component. This is useful for cases where clicking a dropdown item makes a network request and we want to indicate to the user that we are in an in-progress state.

Screenshot_2020-10-21_at_12.18.25_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading