Skip to content

fix(GlButton): Update disabled button icon fill color

Jarek Ostrowski requested to merge 1047-disabled-icon-button-style into master

What does this MR do?

Closes #1047 (closed). Updates the color of the icon in a disabled button. Currently, it's almost indistinguishable from a normal icon in a button, since the fill color actually doesn't change when disabled. It creates confusion as to whether it's actually disabled. Was a finding in gitlab!46205 (comment 437007898).

Screenshots

Before After
Screen_Shot_2020-10-27_at_3.29.10_PM Screen_Shot_2020-10-27_at_3.29.38_PM
Screen_Shot_2020-10-27_at_3.28.52_PM Screen_Shot_2020-10-27_at_3.27.25_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #1047 (closed)

Edited by Jarek Ostrowski

Merge request reports

Loading