Skip to content

feat(GlTabs): Add custom classes to the nav in tabs

Miguel Rincon requested to merge mrincon-custom-tabs-nav-classes into master

What does this MR do?

Allows clients to add their custom nav-class as in the https://bootstrap-vue.org/docs/components/tabs#comp-ref-b-tabs-props:

<gl-tabs nav-class="my-nav-class">
  ...
</gl-tabs>

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports

Loading