Skip to content

fix(dropdown): dropdown accepts `disabled` prop

Miguel Rincon requested to merge 1052-allow-disabled-state-in-dropdown into master

What does this MR do?

Allow dropdown to be disabled by disabled prop. See original comment at: !1807 (comment 440079523).

Issue #1052 (closed)

Why?

When adding the loading state to dropdowns at: !1807 (merged) to set the disabled state, the original disabled prop gets ignored.

  <gl-dropdown :disabled="true"> <!-- the dropdown is not getting disabled! -->
  <gl-dropdown :loading="true" /> <!-- only way to disable this control! -->

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports