Skip to content

Remove unused tooltip for the "Include GitLab CSS Bundle"

Tom Quirk requested to merge remove-css-tooltip into master

What does this MR do?

The Storybook Tooltip component, while we're rendering it, isn't actually used (see "Before" screenshot - you'll notice the little dropdown arrow, with no content). We could use it, but we are already setting the title prop. See screenshots!

Before After
Screen_Shot_2020-11-04_at_3.51.24_pm Screen_Shot_2020-11-04_at_3.45.09_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading